[
https://issues.apache.org/jira/browse/SOLR-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055684#comment-14055684
]
Gregory Chanan commented on SOLR-5656:
--------------------------------------
DocCollection.java
{code}
Line 154: if (maxShardsPerNode == null) {
{code}
Why is this being checked?
https://cwiki.apache.org/confluence/display/solr/Collections+API says
replication factor is required, but not maxShards?
SharedFSAutoReplicaFailoverTest.java
{code}
Line 133: assertTrue("Timeout waiting for all live and active",
ClusterStateUtil.waitForAllActiveAndLive(cloudClient.getZkStateReader(),
collection1, 120));
{code}
How come you only check collection1 throughout this test?
{code}
Line 135: assertSliceAndReplicaCount(collection1);
{code}
What about specifically targeting the node with the overseer
{code}
Line 181: assertEquals(2, slices.size());
{code}
Lots of magic numbers here
SharedFSAutoReplicaFailoverUtilsTest.java
{code}
Line 204: * c = collection, s = slice, r = replica, r\d = node\d, -\d = state
(1=active,2=recovering,3=down,4=recovery_failed), * = bad replica
{code}
I can't figure anything out from this description. Maybe examples would help?
I doubt you are actually saving much space compared to some simple builder.
> Add autoAddReplicas feature for shared file systems.
> ----------------------------------------------------
>
> Key: SOLR-5656
> URL: https://issues.apache.org/jira/browse/SOLR-5656
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-5656.patch, SOLR-5656.patch, SOLR-5656.patch
>
>
> When using HDFS, the Overseer should have the ability to reassign the cores
> from failed nodes to running nodes.
> Given that the index and transaction logs are in hdfs, it's simple for
> surviving hardware to take over serving cores for failed hardware.
> There are some tricky issues around having the Overseer handle this for you,
> but seems a simple first pass is not too difficult.
> This will add another alternative to replicating both with hdfs and solr.
> It shouldn't be specific to hdfs, and would be an option for any shared file
> system Solr supports.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
