[
https://issues.apache.org/jira/browse/SOLR-5656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055639#comment-14055639
]
Gregory Chanan commented on SOLR-5656:
--------------------------------------
An aside: we should probably set up review board for this project. No need to
make it necessary, but it might make it easier to review and thus improve the
number of reviews.
HdfsChaosMonkeySafeLeaderTest.java:
{code}
Line 28: import org.junit.Ignore;
{code}
doesn't seem to be needed
ClusterState.java:
{code}
Line 218: public String getShardIdByCoreNodeName(String collectionName, String
coreNodeName) {
{code}
This is a general comment, but there are a bunch of strings like coreNodeName,
replica names, baseUrls whose relations I'm not sure about (I usually end up
logging them and doing some ad-hoc comparisons). Perhaps turning these into
types with proper conversions would make things clearer? Not necessary for
this patch, just wondering your thoughts.
ClusterStateUtil.java:
{code}
Line 40: * how to wait before giving up{code}
how *long* to wait (this appears multiple times)
{code}
Line 113: for (Replica replica : replicas) {
{code}
can we reduce the amount of duplicate code in these functions?
{code}
Line 200: int timeOutInSeconds) {
{code}
Seconds seem limiting, why not milliseconds?
{code}
Line 242: isAddAddReplicas(...)
{code}
move ZkStateReader to first param to match other functions here
{code}
Line 247: boolean autoAddRepliacs = docCollection.getAutoAddReplicas();
{code}
can just return autoAddReplicas here (also Repliacs is mispelled)
ZkStateReader.java:
{code}
Line 369: for (LiveNodesListener listener : liveNodesListeners) {
{code}
Do we need this? No one seems to be using it. It's a little hard to figure
out the model as well, i.e. it's not called when you explicitly call
updateClusterState. I think the real issue is ZkStateReader is too
complicated, but I haven't thought about how to address that.
{code}
Line 284: controlJetty = createJetty(controlJettyDir, useJettyDataDir ?
getDataDir(testDir
{code}
Why can't we call createControlJetty?
MockZkStateReader.java
There was some comment that this is only necessary temporarily. Is that
already addressed? Is there a JIRA
> Add autoAddReplicas feature for shared file systems.
> ----------------------------------------------------
>
> Key: SOLR-5656
> URL: https://issues.apache.org/jira/browse/SOLR-5656
> Project: Solr
> Issue Type: New Feature
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-5656.patch, SOLR-5656.patch, SOLR-5656.patch
>
>
> When using HDFS, the Overseer should have the ability to reassign the cores
> from failed nodes to running nodes.
> Given that the index and transaction logs are in hdfs, it's simple for
> surviving hardware to take over serving cores for failed hardware.
> There are some tricky issues around having the Overseer handle this for you,
> but seems a simple first pass is not too difficult.
> This will add another alternative to replicating both with hdfs and solr.
> It shouldn't be specific to hdfs, and would be an option for any shared file
> system Solr supports.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
