Thanks for the KIP Boyang! I don't have any further comments.
+1 from me. @Ted: This is a rather simple KIP, thus, skipping the DISCUSS thread seems ok to me. -Matthias @Boyang: it's recommended to use this format for the subject "[VOTE] KIP-245: ..." Same for DISCUSS threads. People are used to those headlines and they pay more attention than. For this KIP, just leave it as it though. For future reference only . On 12/26/17 4:55 AM, Ted Yu wrote: > Normally a DISCUSS thread precedes VOTE thread so that people have ample time > examining the proposal. > -------- Original message --------From: Boyang Chen <bche...@outlook.com> > Date: 12/26/17 1:22 AM (GMT-07:00) To: dev@kafka.apache.org Subject: Vote > for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams > constructor > Hi there, > > I'm Boyang who is a newbie contributor to Kafka. I would like to start a vote > for the KIP-245: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-245%3A+Use+Properties+instead+of+StreamsConfig+in+KafkaStreams+constructor > > > This is linked with JIRA: https://issues.apache.org/jira/browse/KAFKA-6386 > > [KAFKA-6386] Deprecate KafkaStreams constructor taking > ...<https://issues.apache.org/jira/browse/KAFKA-6386> > issues.apache.org > Currently, KafkaStreams constructor has overloads that take either Properties > or StreamsConfig a parameters. Because StreamsConfig is immutable and is > created from a ... > > And my pull request is here: > > > https://github.com/apache/kafka/pull/4354 > > > Since this is my first time doing this, feel free to let me know if this is > the correct format! > > > Best, > > Boyang >
signature.asc
Description: OpenPGP digital signature
