Sure . Thanks,
Mayuresh On Wed, Sep 13, 2017 at 3:12 PM, Jun Rao <j...@confluent.io> wrote: > Hi, Mayuresh, > > Does this KIP obviate the need for KIP-111? If so, could you close that > one? > > Thanks, > > Jun > > On Wed, Sep 13, 2017 at 8:43 AM, Jason Gustafson <ja...@confluent.io> > wrote: > >> Hi All, >> >> I wanted to mention one minor change that came out of the code review. >> We've added an additional method to AuthenticationContext to expose the >> address of the authenticated client. This can be useful, for example, to >> enforce host-based quotas. I've updated the KIP. >> >> Thanks, >> Jason >> >> On Fri, Sep 8, 2017 at 1:12 AM, Edoardo Comar <eco...@uk.ibm.com> wrote: >> >> > I am late to the party and my +1 vote is useless - but I took eventually >> > the time to go through it and it's a great improvement. >> > It'd enable us to carry along with the Principal a couple of additional >> > attributes without the hacks we're doing today :-) >> > >> > cheers >> > -------------------------------------------------- >> > >> > Edoardo Comar >> > >> > IBM Message Hub >> > >> > IBM UK Ltd, Hursley Park, SO21 2JN >> > >> > >> > >> > From: Jason Gustafson <ja...@confluent.io> >> > To: dev@kafka.apache.org >> > Date: 07/09/2017 17:23 >> > Subject: Re: [VOTE] KIP-189 - Improve principal builder interface >> > and add support for SASL >> > >> > >> > >> > I am closing the vote. Here are the totals: >> > >> > Binding: Ismael, Rajini, Jun, (Me) >> > Non-binding: Mayuresh, Manikumar, Mickael >> > >> > Thanks all for the reviews! >> > >> > >> > >> > On Wed, Sep 6, 2017 at 2:22 PM, Jason Gustafson <ja...@confluent.io> >> > wrote: >> > >> > > Hi All, >> > > >> > > When implementing this, I found that the SecurityProtocol class has >> some >> > > internal details which we might not want to expose to users (in >> > particular >> > > to enable testing). Since it's still useful to know the security >> > protocol >> > > in use in some cases, and since the security protocol names are >> already >> > > exposed in configuration (and hence cannot easily change), I have >> > modified >> > > the method in AuthenticationContext to return the name of the security >> > > protocol instead. Let me know if there are any concerns with this >> > change. >> > > Otherwise, I will close out the vote. >> > > >> > > Thanks, >> > > Jason >> > > >> > > On Tue, Sep 5, 2017 at 11:10 AM, Ismael Juma <ism...@juma.me.uk> >> wrote: >> > > >> > >> Thanks for the KIP, +1 (binding). >> > >> >> > >> Ismael >> > >> >> > >> On Wed, Aug 30, 2017 at 4:51 PM, Jason Gustafson <ja...@confluent.io >> > >> > >> wrote: >> > >> >> > >> > I'd like to open the vote for KIP-189: >> > >> > >> > https://urldefense.proofpoint.com/v2/url?u=https-3A__cwiki. >> > apache.org_confluence_display_KAFKA_KIP-2D&d=DwIBaQ&c=jf_ >> > iaSHvJObTbx-siA1ZOg&r=EzRhmSah4IHsUZVekRUIINhltZK7U0OaeRo7hgW4_tQ&m= >> > 8TbXL3wrbGFsuFCex8zcLvXRZAxdxLXNvEzr4K-VfSQ&s= >> > zDCjH3kSYjz3pYaMq9En4suoqr4LNK54NfE95khHkRo&e= >> > >> > >> > 189%3A+Improve+principal+builder+interface+and+add+support+ >> for+SASL. >> > >> > Thanks to everyone who helped review. >> > >> > >> > >> > -Jason >> > >> > >> > >> >> > > >> > > >> > >> > >> > >> > Unless stated otherwise above: >> > IBM United Kingdom Limited - Registered in England and Wales with number >> > 741598. >> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 >> 3AU >> > >> > > -- -Regards, Mayuresh R. Gharat (862) 250-7125
