Hi All, When implementing this, I found that the SecurityProtocol class has some internal details which we might not want to expose to users (in particular to enable testing). Since it's still useful to know the security protocol in use in some cases, and since the security protocol names are already exposed in configuration (and hence cannot easily change), I have modified the method in AuthenticationContext to return the name of the security protocol instead. Let me know if there are any concerns with this change. Otherwise, I will close out the vote.
Thanks, Jason On Tue, Sep 5, 2017 at 11:10 AM, Ismael Juma <ism...@juma.me.uk> wrote: > Thanks for the KIP, +1 (binding). > > Ismael > > On Wed, Aug 30, 2017 at 4:51 PM, Jason Gustafson <ja...@confluent.io> > wrote: > > > I'd like to open the vote for KIP-189: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 189%3A+Improve+principal+builder+interface+and+add+support+for+SASL. > > Thanks to everyone who helped review. > > > > -Jason > > >
