Hey Jun, I will add a note to the KIP, but my plan was to dynamically check whether the KafkaPrincipalBuilder implemented Configurable or Closeable. That makes implementing close() and configure() optional. Does that seem reasonable?
-Jason On Thu, Aug 31, 2017 at 9:53 AM, Jun Rao <j...@confluent.io> wrote: > Hi, Jason, > > Thanks for the KIP. +1. Just one minor comment. It seems that the new > KafkaPrincipalBuilder > interface should support Configurable and close() as the existing > PrincipalBuilder? > > Jun > > On Wed, Aug 30, 2017 at 8:51 AM, Jason Gustafson <ja...@confluent.io> > wrote: > > > I'd like to open the vote for KIP-189: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > 189%3A+Improve+principal+builder+interface+and+add+support+for+SASL. > > Thanks to everyone who helped review. > > > > -Jason > > >
