[
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184535#comment-15184535
]
chen zhu commented on KAFKA-3261:
---------------------------------
[~guozhang] I am sorry for the late reply.
Are you suggesting to construct a new class that contains 4 fields: host, port,
broker id and protocol id, and allow broker id and protocol id to be None? If
so, that is certainly doable. But do you think this is better than current
implementation?
BTW, could you please explain ".. versioned based on protocol id"? I don't have
experience with that. Thanks!
> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -------------------------------------------------------------------------
>
> Key: KAFKA-3261
> URL: https://issues.apache.org/jira/browse/KAFKA-3261
> Project: Kafka
> Issue Type: Bug
> Reporter: Guozhang Wang
> Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN =
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
