[ 
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176557#comment-15176557
 ] 

Guozhang Wang commented on KAFKA-3261:
--------------------------------------

[~ijuma][~chenzhu] Since both of these classes are internal, could we just make 
a new class (or just augment one of these two) that contain all of these 
fields, and is versioned based on the protocol id?

> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -------------------------------------------------------------------------
>
>                 Key: KAFKA-3261
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3261
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>            Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also 
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use 
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN = 
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to