[ 
https://issues.apache.org/jira/browse/KAFKA-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170945#comment-15170945
 ] 

chen zhu commented on KAFKA-3261:
---------------------------------

[~guozhang], it looks like we can not consolidate kafka.cluster.BrokerEndPoint 
and kafka.cluster.EndPoint because they actually have different contents and 
usage. BrokerEndPoint contains host, port and broker id whereas EndPoint 
contains host, port and protocol id. Do you think this ticket should be closed?

> Consolidate class kafka.cluster.BrokerEndPoint and kafka.cluster.EndPoint
> -------------------------------------------------------------------------
>
>                 Key: KAFKA-3261
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3261
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Guozhang Wang
>            Assignee: chen zhu
>
> These two classes are serving similar purposes and can be consolidated. Also 
> as [~sasakitoa] suggested we can remove their "uriParseExp" variables but use 
> (a possibly modified)
> {code}
> private static final Pattern HOST_PORT_PATTERN = 
> Pattern.compile(".*?\\[?([0-9a-zA-Z\\-.:]*)\\]?:([0-9]+)");
> {code}
> in org.apache.kafka.common.utils.Utils instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to