[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112045#comment-15112045 ]
David Jacot commented on KAFKA-2066: ------------------------------------ [~becket_qin], indeed replacing MessageSet with Records is better than having some sort of conversion. [~ijuma], [~becket_qin], overall the plan looks like this: 1. Use Records in the requests/reponses. This also requires to update Producer and Consumer. 2. Extend serialization system to support Records and Channel (for the zero-copy). This also requires to add more methods in Records (writeTo, ...). 3. Replace MessageSet with Records on the broker side. 4. Replace FetchRequest / FetchResponse with their org.apache.kafka.common.requests equivalents. I have started to work on 1) and 2). I'll take care of the broker side after. Is is OK to keep such a big batch of changes in the same patch or should we break it into several paths? > Replace FetchRequest / FetchResponse with their > org.apache.kafka.common.requests equivalents > -------------------------------------------------------------------------------------------- > > Key: KAFKA-2066 > URL: https://issues.apache.org/jira/browse/KAFKA-2066 > Project: Kafka > Issue Type: Sub-task > Reporter: Gwen Shapira > Assignee: David Jacot > > Replace FetchRequest / FetchResponse with their > org.apache.kafka.common.requests equivalents. > Note that they can't be completely removed until we deprecate the > SimpleConsumer API (and it will require very careful patchwork for the places > where core modules actually use the SimpleConsumer API). > This also requires a solution on how to stream from memory-mapped files > (similar to what existing code does with FileMessageSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)