[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106721#comment-15106721 ]
Ismael Juma commented on KAFKA-2066: ------------------------------------ [~dajac], I am not sure about making `MessageSet` inherit from `Records`. The rest seems to make sense. A couple of things. * The PR for KIP-31 and KIP-32 makes some changes to the relevant classes: https://github.com/apache/kafka/pull/764 * We need to ensure compatibility for SimpleConsumer that exposes MessageSet via FetchResponse and FetchResponsePartitionData. > Replace FetchRequest / FetchResponse with their > org.apache.kafka.common.requests equivalents > -------------------------------------------------------------------------------------------- > > Key: KAFKA-2066 > URL: https://issues.apache.org/jira/browse/KAFKA-2066 > Project: Kafka > Issue Type: Sub-task > Reporter: Gwen Shapira > Assignee: David Jacot > > Replace FetchRequest / FetchResponse with their > org.apache.kafka.common.requests equivalents. > Note that they can't be completely removed until we deprecate the > SimpleConsumer API (and it will require very careful patchwork for the places > where core modules actually use the SimpleConsumer API). > This also requires a solution on how to stream from memory-mapped files > (similar to what existing code does with FileMessageSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)