[ https://issues.apache.org/jira/browse/KAFKA-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111034#comment-15111034 ]
Jiangjie Qin commented on KAFKA-2066: ------------------------------------- [~dajac] [~ijuma] I was thinking about this when writing the patch for KIP-31 and KIP-32. 1. zero-copy takes place in FileMessageSet, so a new subclass of Records (eg. FileRecords) should be created. 2. Current Records interface is very simple. We need to add more methods to it. Because after KIP-31 and KIP-32 we sometimes need to do message format conversion, that requires MemoryRecords and FileRecords has at least the same interface of writeTo(). 3. We probably don't need MessageSet to Records conversion. What we can do is to replace all MessageSet used on broker side with Records. So MessageSet will only be used in SimpleConsumer. Thoughts? > Replace FetchRequest / FetchResponse with their > org.apache.kafka.common.requests equivalents > -------------------------------------------------------------------------------------------- > > Key: KAFKA-2066 > URL: https://issues.apache.org/jira/browse/KAFKA-2066 > Project: Kafka > Issue Type: Sub-task > Reporter: Gwen Shapira > Assignee: David Jacot > > Replace FetchRequest / FetchResponse with their > org.apache.kafka.common.requests equivalents. > Note that they can't be completely removed until we deprecate the > SimpleConsumer API (and it will require very careful patchwork for the places > where core modules actually use the SimpleConsumer API). > This also requires a solution on how to stream from memory-mapped files > (similar to what existing code does with FileMessageSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)