[ https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695575#comment-14695575 ]
Ismael Juma commented on KAFKA-2411: ------------------------------------ I pushed an additional commit that updates `ControllerChannelManager` to use `Selector` and I've replaced the PR to master with one that targets the SSL/TLS branch in my fork (so that it only shows the relevant commits): https://github.com/ijuma/kafka/pull/5 I made the simplest possible change for now. I've started experimenting with the changes to `AbstractFetcherThread`, but still interested in feedback on the two commits in the PR. > remove usage of BlockingChannel in the broker > --------------------------------------------- > > Key: KAFKA-2411 > URL: https://issues.apache.org/jira/browse/KAFKA-2411 > Project: Kafka > Issue Type: Sub-task > Components: security > Reporter: Jun Rao > Assignee: Ismael Juma > Fix For: 0.8.3 > > > In KAFKA-1690, we are adding the SSL support at Selector. However, there are > still a few places where we use BlockingChannel for inter-broker > communication. We need to replace those usage with Selector/NetworkClient to > enable inter-broker communication over SSL. Specially, BlockingChannel is > currently used in the following places. > 1. ControllerChannelManager: for the controller to propagate metadata to the > brokers. > 2. KafkaServer: for the broker to send controlled shutdown request to the > controller. > 3. AbstractFetcherThread: for the follower to fetch data from the leader > (through SimpleConsumer). -- This message was sent by Atlassian JIRA (v6.3.4#6332)