[ 
https://issues.apache.org/jira/browse/KAFKA-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680045#comment-14680045
 ] 

ASF GitHub Bot commented on KAFKA-2411:
---------------------------------------

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/127

    KAFKA-2411; [WIP] remove usage of blocking channel

    This PR builds on the work from @harshach and only the last commit is 
relevant. Opening the PR for getting feedback.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka 
kafka-2411-remove-usage-of-blocking-channel

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 8ca558920347733ddf7a924463c93620e976a3f3
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-04-28T07:29:53Z

    KAFKA-1690. new java producer needs ssl support as a client.

commit 754a121e7582f1452a9ae3a3ab72c58cf284da1d
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-11T06:02:01Z

    KAFKA-1690. new java producer needs ssl support as a client.

commit 98a90ae9d80ea8f5ab4780569d1c4e301dd16c4e
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-11T06:18:13Z

    KAFKA-1690. new java producer needs ssl support as a client.

commit 804da7a015be2f98a1bb867ee5d42aa8009a37dd
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-11T06:31:25Z

    KAFKA-1690. new java producer needs ssl support as a client.

commit ee16e8e6f92ac2baf0e41d3019b7f8aef39b1506
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-11T23:09:01Z

    KAFKA-1690. new java producer needs ssl support as a client. SSLFactory 
tests.

commit 2dd826be4a6ebe7064cb19ff21fe23950a1bafc2
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-12T23:09:38Z

    KAFKA-1690. new java producer needs ssl support as a client. Added 
PrincipalBuilder.

commit 2cddad80f6a4a961b6932879448e532dab4e637e
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-15T14:17:37Z

    KAFKA-1690. new java producer needs ssl support as a client. Addressing 
reviews.

commit ca0456dc01def337ee1711cabd9c4e9df4af61ee
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-20T21:23:29Z

    KAFKA-1690. new java producer needs ssl support as a client. Addressing 
reviews.

commit 7e3a4cfc58932aab4288677111af52f94c9012b6
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-20T21:37:52Z

    KAFKA-1690. new java producer needs ssl support as a client. Addressing 
reviews.

commit 9bdc0000eb24f8682184f7fb39578f239a7b6dde
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-21T16:50:52Z

    KAFKA-1690. new java producer needs ssl support as a client. Fixed minor
    issues with the patch.

commit 65396b5cabeaf61579c6e6422848877fc7a896a9
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-21T17:27:11Z

    KAFKA-1690. new java producer needs ssl support as a client. Fixed minor 
issues with the patch.

commit b37330a7b4ec3adfba4f0c6e33ab172be03406be
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-05-29T03:57:06Z

    KAFKA-1690. new java producer needs ssl support as a client.

commit fe595fd4fda45ebd7c5da88ee093ab17817bb94d
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-06-04T01:43:34Z

    KAFKA-1690. new java producer needs ssl support as a client.

commit 247264ce35a04d14b97c87dcb88378ad1dbe0986
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-06-08T16:07:14Z

    Merge remote-tracking branch 'refs/remotes/origin/trunk' into KAFKA-1690-V1

commit 050782b9f47f4c61b22ef065ec4798ccbdb962d3
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-06-16T15:46:05Z

    KAFKA-1690. Broker side ssl changes.

commit 9328ffa464711a835be8935cb09922230e0e1a58
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-06-20T17:47:01Z

    KAFKA-1684. SSL for socketServer.

commit eda92cb5f9d2ae749903eac5453a6fdb49685964
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-06-21T03:01:30Z

    KAFKA-1690. Added SSLProducerSendTest and fixes to get right port for SSL.

commit f10e28b2f2b10d91db9c1aba977fc578b4c4c633
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-06-21T03:47:54Z

    Merge branch 'trunk' into KAFKA-1690-V1

commit f60c95273b3b814792d0da9264a75939049dcc5f
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-06-21T04:45:58Z

    KAFKA-1690. Post merge fixes.

commit 8f7ba892502b09cb7cc05d75270352815fb1c42c
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-06-21T22:35:52Z

    KAFKA-1690. Added SSLProducerSendTest.

commit 0dba29f7bd5489163949641030a98c308f25cb67
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-06-23T16:16:29Z

    KAFKA-1690. Minor fixes based on patch review comments.

commit e44c90e4ce4c36243b1211e25e89d41e82acaf4e
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-07-11T03:05:44Z

    Merge commit

commit 737813f08ed60e9bd39d5b2baa0bea1b624d6fa6
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-07-18T03:31:51Z

    KAFKA-1690. Added SSL Consumer Test.

commit ac957b562fccb1c1e9868e7fea67828f3e0d76b9
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-07-18T21:01:04Z

    KAFKA-1690. SSL Support.

commit 4338f464896314de1989e196a3be0eac255e7b6f
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-07-20T00:24:46Z

    KAFKA-1690. Addressing reviews.

commit 8a95071426fa625b77366039bed7bc6c49762ccd
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-07-20T01:17:30Z

    Merge branch 'trunk' into KAFKA-1690-V1

commit 0699537da7353a1a382e95657a0d6e7f33ea190c
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-07-20T04:18:51Z

    Merge branch 'trunk' into KAFKA-1690-V1

commit 2d93f2448a4a2b4285dd1803b9f17c96ce1a796c
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-07-20T16:44:03Z

    KAFKA-1690. Addressing reviews. Removed interestOps from SSLTransportLayer.

commit 2fb226d58e1016ec1665b8996dbd956da952d29c
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-07-20T18:17:17Z

    KAFKA-1690. Addressing reviews.

commit ddec2cfd6b84f4a8b8161f8f537d457b48b90140
Author: Sriharsha Chintalapani <har...@hortonworks.com>
Date:   2015-07-25T06:07:59Z

    KAFKA-1690. added staged receives to selector.

----


> remove usage of BlockingChannel in the broker
> ---------------------------------------------
>
>                 Key: KAFKA-2411
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2411
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: security
>            Reporter: Jun Rao
>            Assignee: Ismael Juma
>             Fix For: 0.8.3
>
>
> In KAFKA-1690, we are adding the SSL support at Selector. However, there are 
> still a few places where we use BlockingChannel for inter-broker 
> communication. We need to replace those usage with Selector/NetworkClient to 
> enable inter-broker communication over SSL. Specially, BlockingChannel is 
> currently used in the following places.
> 1. ControllerChannelManager: for the controller to propagate metadata to the 
> brokers.
> 2. KafkaServer: for the broker to send controlled shutdown request to the 
> controller.
> 3. AbstractFetcherThread: for the follower to fetch data from the leader 
> (through SimpleConsumer).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to