----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review85154 -----------------------------------------------------------
core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala <https://reviews.apache.org/r/34641/#comment136659> Should we also consider reassignments that are in-progress as "errors"? The reasoning is that you'd like to do the following in (say) Ansible: "Trigger reassignment of partitions, wait until all are completed, and only then continue with the next action." That being said, there are other ways to achieve this in tools like Ansible. For instance, you can trigger reassignents, then repeatedly call `--verify` in a loop and capture its STDOUT, looking for "is still in progress" and "failed". However, this is arguably more error prone because the log messages can change between Kafka versions (and oftentimes such changes are not prominently advertised, so you only notice this once your deployment script breaks). - Michael Noll On May 24, 2015, 11:58 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34641/ > ----------------------------------------------------------- > > (Updated May 24, 2015, 11:58 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2214 > https://issues.apache.org/jira/browse/KAFKA-2214 > > > Repository: kafka > > > Description > ------- > > kafka-reassign-partitions.sh: return non-zero error status on failures > > > Diffs > ----- > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > acaa6112db979dc775af6385c58d2e52786dfba9 > > Diff: https://reviews.apache.org/r/34641/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
