----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review92024 -----------------------------------------------------------
Just realized that verifyAssigment runs on a Map of <Partition, Status> and originally printed status for each partition (some can succeed, fail or be in-progress). We need to return a single error code. In the existing code, we return 0 if all partitions were successfull, 1 if one or more failed, 2 if one of more is in progress. If some are in-progress and some are failed, it seems like the return value is either 1 or 2, at random (since it depends on order of foreach on a Map). I'm not sure thats expected :) Perhaps we can come up with something better defined? - Gwen Shapira On July 14, 2015, 10:13 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34641/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 10:13 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2214 > https://issues.apache.org/jira/browse/KAFKA-2214 > > > Repository: kafka > > > Description > ------- > > Addressing Gwen's comments > > > Diffs > ----- > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > ea345895a52977c25bff57e95e12b8662331d7fe > > Diff: https://reviews.apache.org/r/34641/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
