----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34641/#review91314 -----------------------------------------------------------
Thanks for the patch. Lets streamline error handling a bit. Also, can you post sample output to the JIRA, so we can make sure the errors are use-friendly? core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala (lines 60 - 61) <https://reviews.apache.org/r/34641/#comment144627> Can we just exit in the exception clause? core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala (line 79) <https://reviews.apache.org/r/34641/#comment144625> why not re-throw? APIs that can both return error codes and throw exceptions are pretty confusing (you need to handle errors in two different ways). - Gwen Shapira On July 10, 2015, 4:28 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34641/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 4:28 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2214 > https://issues.apache.org/jira/browse/KAFKA-2214 > > > Repository: kafka > > > Description > ------- > > rebase > > > Diffs > ----- > > core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala > ea345895a52977c25bff57e95e12b8662331d7fe > > Diff: https://reviews.apache.org/r/34641/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
