----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74379 -----------------------------------------------------------
Thanks for the patch. Some comments below. examples/src/main/java/kafka/examples/Consumer.java <https://reviews.apache.org/r/31369/#comment120946> It would be useful to print out the key as well. examples/src/main/java/kafka/examples/Producer.java <https://reviews.apache.org/r/31369/#comment120947> Perhaps we can create an IntegerSerializer and send messageNo as the key? examples/src/main/java/kafka/examples/Producer.java <https://reviews.apache.org/r/31369/#comment120948> It's probably better to print each mesage in a single line and print out the key as well. - Jun Rao On Feb. 25, 2015, 4:48 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31369/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 4:48 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1982 > https://issues.apache.org/jira/browse/KAFKA-1982 > > > Repository: kafka > > > Description > ------- > > KAFKA-1982: change kafka.examples.Producer to use the new java producer > > > Diffs > ----- > > examples/src/main/java/kafka/examples/Consumer.java > 13135b954f3078eeb7394822b0db25470b746f03 > examples/src/main/java/kafka/examples/Producer.java > 96e98933148d07564c1b30ba8e805e2433c2adc8 > > Diff: https://reviews.apache.org/r/31369/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
