> On Feb. 26, 2015, 10:27 p.m., Jun Rao wrote: > > examples/src/main/java/kafka/examples/Consumer.java, line 62 > > <https://reviews.apache.org/r/31369/diff/4/?file=875219#file875219line62> > > > > It would be useful to print out the key as well.
Added > On Feb. 26, 2015, 10:27 p.m., Jun Rao wrote: > > examples/src/main/java/kafka/examples/Producer.java, line 53 > > <https://reviews.apache.org/r/31369/diff/4/?file=875220#file875220line53> > > > > Perhaps we can create an IntegerSerializer and send messageNo as the > > key? Done > On Feb. 26, 2015, 10:27 p.m., Jun Rao wrote: > > examples/src/main/java/kafka/examples/Producer.java, lines 81-88 > > <https://reviews.apache.org/r/31369/diff/4/?file=875220#file875220line81> > > > > It's probably better to print each mesage in a single line and print > > out the key as well. Done - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74379 ----------------------------------------------------------- On Feb. 27, 2015, 7:08 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31369/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 7:08 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1982 > https://issues.apache.org/jira/browse/KAFKA-1982 > > > Repository: kafka > > > Description > ------- > > KAFKA-1982: change kafka.examples.Producer to use the new java producer > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/common/serialization/IntegerDeserializer.java > PRE-CREATION > > clients/src/main/java/org/apache/kafka/common/serialization/IntegerSerializer.java > PRE-CREATION > examples/src/main/java/kafka/examples/Consumer.java > 13135b954f3078eeb7394822b0db25470b746f03 > examples/src/main/java/kafka/examples/Producer.java > 96e98933148d07564c1b30ba8e805e2433c2adc8 > > Diff: https://reviews.apache.org/r/31369/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
