> On Nov. 11, 2014, 5:06 a.m., Joe Stein wrote: > > Vagrantfile, line 40 > > <https://reviews.apache.org/r/27735/diff/1/?file=754605#file754605line40> > > > > It might be worth adding somethign about this in the README as it might > > be start to come up on the mailing list a bit
The security group was mentioned in the README, but I've expanded it to explain what ports you need to open up and that you should be careful about opening those ports to the world. > On Nov. 11, 2014, 5:06 a.m., Joe Stein wrote: > > vagrant/README.md, line 31 > > <https://reviews.apache.org/r/27735/diff/1/?file=754606#file754606line31> > > > > So, a couple things here. > > > > 1) I don't think we need to call these things out in the README. They > > can be in the comments, sure. > > > > 2) I don't think that zookeeper issue is at play here though, that > > issue is why folks run 5 zk in AWS in prod so they have HA not sure how it > > relates to here (since we are not changing the DNS and IP) > > > > 3) I do like the extra step because it allows all 3 zookeeper servers > > to get configured first (which is required) and then turned on. > > > > So, think we shoud just remove all 3 lines entirely I added that note since the two steps would probably be confusing to anyone familiar with Vagrant. The issue with ZK has to do with DNS. It's not safe to start ZK until after vagrant-hostmanager has added the hostnames to /etc/hosts because ZK will cache the DNS lookup (which is what that JIRA is about) and will never be able to connect to the other nodes, and then of course Kafka won't be able to start up either. > On Nov. 11, 2014, 5:06 a.m., Joe Stein wrote: > > vagrant/base.sh, line 41 > > <https://reviews.apache.org/r/27735/diff/1/?file=754607#file754607line41> > > > > I like /opt/apache/kafka but /opt/kafka is ok too :) just nit picking I took the path from your original patch :) Happy to change it, but unless there's some existing code that relies on the specific path I don't think it matters much. We could also just make this configurable... > On Nov. 11, 2014, 5:06 a.m., Joe Stein wrote: > > vagrant/broker.sh, line 38 > > <https://reviews.apache.org/r/27735/diff/1/?file=754608#file754608line38> > > > > hmmm, this is something I can see folks messing with a lot and doing > > vagrant provision to get it right... having it outside the vm and available > > makes sense but I hate litering the repo maybe to make sure it doesn't get > > committed add it to the .gitignore? config/server-* or something? Actually this hasn't been a problem for me because Vagrant has been using rsync for the synced folder, both with VirtualBox and EC2. Files weren't getting synced back to the host. For EC2 it makes sense, and I guess the base box must not have virtualbox guest additions. I've added these to the .gitignore anyway since it doesn't hurt. - Ewen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27735/#review60747 ----------------------------------------------------------- On Nov. 11, 2014, 9:51 p.m., Ewen Cheslack-Postava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27735/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 9:51 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1173 > https://issues.apache.org/jira/browse/KAFKA-1173 > > > Repository: kafka > > > Description > ------- > > Add basic EC2 support, cleaner Vagrantfile, README cleanup, etc. > > > Better naming, hostmanager for routable VM names, vagrant-cachier to reduce > startup cost, cleanup provisioning scripts, initial support for multiple > zookeepers, general cleanup. > > > Don't sync a few directories that aren't actually required on the server. > > > Add generic worker node support. > > > Default # of workers should be 0 > > > Add support for Zookeeper clusters. > > This requires us to split up allocating VMs and provisioning because Vagrant > will run the provisioner for the first node before all nodes are allocated. > This > leaves the first node running Zookeeper with unroutable peer hostnames which > it, > for some reason, caches as unroutable. The cluster never properly finishes > forming since the nodes are unable to open connections to nodes booted later > than they were. The simple solution is to make sure all nodes are booted > before > starting configuration so we have all the addresses and hostnames available > and > routable. > > Fix AWS provider commands in Vagrant README. > > > Addressing Joe's comments. > > > Diffs > ----- > > .gitignore 99b32a6770e3da59bc0167d77d45ca339ac3dbbd > README.md 9aca90664b2a80a37125775ddbdea06ba6c53644 > Vagrantfile PRE-CREATION > vagrant/README.md PRE-CREATION > vagrant/base.sh PRE-CREATION > vagrant/broker.sh PRE-CREATION > vagrant/zk.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/27735/diff/ > > > Testing > ------- > > > Thanks, > > Ewen Cheslack-Postava > >
