----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27735/#review60747 -----------------------------------------------------------
Vagrantfile <https://reviews.apache.org/r/27735/#comment102141> Haven't tried this yet, have more testing I want to-do will try it tomorrow. Vagrantfile <https://reviews.apache.org/r/27735/#comment102146> It might be worth adding somethign about this in the README as it might be start to come up on the mailing list a bit Vagrantfile <https://reviews.apache.org/r/27735/#comment102142> We can probably make the RAM settings configured like the other settings in one place? Vagrantfile <https://reviews.apache.org/r/27735/#comment102136> can remove these if we move to using the ENV vagrant/README.md <https://reviews.apache.org/r/27735/#comment102138> This worked great :) I did have to upgrade my vagrant (been meaning to-do this for a while was on 1.6.3 and moved to 1.6.5) not sure if we want to let folks know >= 1.6.4 (I think that might work but not sure (from the error it seemed that way ... , we could just say 1.6.5 or later?) Here was the error exactly ... An error occurred while installing nokogiri (1.6.4.1), and Bundler cannot continue. Make sure that `gem install nokogiri -v '1.6.4.1'` succeeds before bundling. vagrant/README.md <https://reviews.apache.org/r/27735/#comment102139> I always have to-do vagrant up --provider=virtualbox --no-provision && vagrant provision otherwise i get an error looking for vmware box... this is a local thing other folks might/will have it but they should already know about it. I don't think we need to change this but bringing it up in case folks get vm: * A box must be specified. vagrant/README.md <https://reviews.apache.org/r/27735/#comment102140> So, a couple things here. 1) I don't think we need to call these things out in the README. They can be in the comments, sure. 2) I don't think that zookeeper issue is at play here though, that issue is why folks run 5 zk in AWS in prod so they have HA not sure how it relates to here (since we are not changing the DNS and IP) 3) I do like the extra step because it allows all 3 zookeeper servers to get configured first (which is required) and then turned on. So, think we shoud just remove all 3 lines entirely vagrant/README.md <https://reviews.apache.org/r/27735/#comment102147> I can imagine this confusing people :/ maybe be more explicit and write out all 3 for each with ip or for host, just to spoon feed it some otherwise it will undoubtly come up by someone somewhere for some reason. could be fine too as it is vagrant/README.md <https://reviews.apache.org/r/27735/#comment102149> I see, you are using the Vagrantfile.local for all of your setting for ignoring it, that is why you aren't using the ENV variables for the EC2 keys. I totally missed that in my first pass through it wasn't obvious to me, but could just be tired. vagrant/README.md <https://reviews.apache.org/r/27735/#comment102137> We should document here if we use the ENV vagrant/base.sh <https://reviews.apache.org/r/27735/#comment102143> I like /opt/apache/kafka but /opt/kafka is ok too :) just nit picking vagrant/broker.sh <https://reviews.apache.org/r/27735/#comment102144> hmmm, this is something I can see folks messing with a lot and doing vagrant provision to get it right... having it outside the vm and available makes sense but I hate litering the repo maybe to make sure it doesn't get committed add it to the .gitignore? config/server-* or something? vagrant/zk.sh <https://reviews.apache.org/r/27735/#comment102145> i think we should add to .gitignore config/zookeeper-* - Joe Stein On Nov. 7, 2014, 6:25 p.m., Ewen Cheslack-Postava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27735/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 6:25 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1173 > https://issues.apache.org/jira/browse/KAFKA-1173 > > > Repository: kafka > > > Description > ------- > > Add basic EC2 support, cleaner Vagrantfile, README cleanup, etc. > > > Better naming, hostmanager for routable VM names, vagrant-cachier to reduce > startup cost, cleanup provisioning scripts, initial support for multiple > zookeepers, general cleanup. > > > Don't sync a few directories that aren't actually required on the server. > > > Add generic worker node support. > > > Default # of workers should be 0 > > > Add support for Zookeeper clusters. > > This requires us to split up allocating VMs and provisioning because Vagrant > will run the provisioner for the first node before all nodes are allocated. > This > leaves the first node running Zookeeper with unroutable peer hostnames which > it, > for some reason, caches as unroutable. The cluster never properly finishes > forming since the nodes are unable to open connections to nodes booted later > than they were. The simple solution is to make sure all nodes are booted > before > starting configuration so we have all the addresses and hostnames available > and > routable. > > Fix AWS provider commands in Vagrant README. > > > Diffs > ----- > > .gitignore 99b32a6770e3da59bc0167d77d45ca339ac3dbbd > Vagrantfile PRE-CREATION > vagrant/README.md PRE-CREATION > vagrant/base.sh PRE-CREATION > vagrant/broker.sh PRE-CREATION > vagrant/zk.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/27735/diff/ > > > Testing > ------- > > > Thanks, > > Ewen Cheslack-Postava > >
