> On Nov. 11, 2014, 4:40 a.m., Joe Stein wrote: > > Vagrantfile, line 30 > > <https://reviews.apache.org/r/27735/diff/1/?file=754605#file754605line30> > > > > we should use the enviornment variable AWS_ACCESS_KEY and > > AWS_SECRET_KEY which vagrant aws provider will read instead > > https://github.com/mitchellh/vagrant-aws/blob/master/lib/vagrant-aws/config.rb#L257-L258 > > Joe Stein wrote: > Ok, I realized that you are using Vagrantfile.local for the configs so I > think that there is not need to ALSO then export the AWS_ACCESS_KEY and > AWS_SECRET_KEY which would be total overkill. Maybe just make that a bit > more clear in the README for folks?
Actually, I think supporting this is a good idea so I've added it. It's trivial to support and many people expect this to work. I happen to dislike that approach because I work with multiple AWS accounts so using environment variables can easily lead to using the wrong account by mistake, but it works well for many people. - Ewen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27735/#review60746 ----------------------------------------------------------- On Nov. 11, 2014, 9:51 p.m., Ewen Cheslack-Postava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27735/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 9:51 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1173 > https://issues.apache.org/jira/browse/KAFKA-1173 > > > Repository: kafka > > > Description > ------- > > Add basic EC2 support, cleaner Vagrantfile, README cleanup, etc. > > > Better naming, hostmanager for routable VM names, vagrant-cachier to reduce > startup cost, cleanup provisioning scripts, initial support for multiple > zookeepers, general cleanup. > > > Don't sync a few directories that aren't actually required on the server. > > > Add generic worker node support. > > > Default # of workers should be 0 > > > Add support for Zookeeper clusters. > > This requires us to split up allocating VMs and provisioning because Vagrant > will run the provisioner for the first node before all nodes are allocated. > This > leaves the first node running Zookeeper with unroutable peer hostnames which > it, > for some reason, caches as unroutable. The cluster never properly finishes > forming since the nodes are unable to open connections to nodes booted later > than they were. The simple solution is to make sure all nodes are booted > before > starting configuration so we have all the addresses and hostnames available > and > routable. > > Fix AWS provider commands in Vagrant README. > > > Addressing Joe's comments. > > > Diffs > ----- > > .gitignore 99b32a6770e3da59bc0167d77d45ca339ac3dbbd > README.md 9aca90664b2a80a37125775ddbdea06ba6c53644 > Vagrantfile PRE-CREATION > vagrant/README.md PRE-CREATION > vagrant/base.sh PRE-CREATION > vagrant/broker.sh PRE-CREATION > vagrant/zk.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/27735/diff/ > > > Testing > ------- > > > Thanks, > > Ewen Cheslack-Postava > >
