> On Oct. 7, 2014, 11:03 p.m., Jun Rao wrote: > > core/src/test/scala/unit/kafka/log/LogTest.scala, line 242 > > <https://reviews.apache.org/r/26346/diff/5/?file=714849#file714849line242> > > > > By increasing the segment size to 100, does the log still roll on every > > message as indicated by the comment? > > Sriharsha Chintalapani wrote: > yes it rolls on every messageset. I can add a assert to test that if it > required. > > Jun Rao wrote: > Will it? In each append, we add 2 messages with a total of 10 bytes. If > we add a 10 byte per message overhead, with compression, it seems both > message sets can fit in the same log segment of 100 bytes? > > Sriharsha Chintalapani wrote: > I am using validMessages.sizeInBytes which is showing the size of > ByteBufferedMessageSet > new ByteBufferMessageSet(DefaultCompressionCodec, new > Message("hello".getBytes), new Message("there".getBytes)) as 83
Great. Then, this is fine. - Jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26346/#review55720 ----------------------------------------------------------- On Oct. 7, 2014, 8:49 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26346/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 8:49 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1670 > https://issues.apache.org/jira/browse/KAFKA-1670 > > > Repository: kafka > > > Description > ------- > > KAFKA-1670. Corrupt log files for segment.bytes values close to Int.MaxInt. > > > KAFKA-1670. Corrupt log files for segment.bytes values close to Int.MaxInt. > > > KAFKA-1670. Corrupt log files for segment.bytes values close to Int.MaxInt. > > > KAFKA-1670. Corrupt log files for segment.bytes values close to Int.MaxInt. > > > Diffs > ----- > > core/src/main/scala/kafka/common/MessageSetSizeTooLargeException.scala > PRE-CREATION > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > core/src/test/scala/unit/kafka/log/LogManagerTest.scala > 59bd8a981b3fb8595dd6e790a30071092978a88d > core/src/test/scala/unit/kafka/log/LogTest.scala > 577d102fc2eb6bb1a72326141ecd431db6d66f04 > core/src/test/scala/unit/kafka/server/LogOffsetTest.scala > 9556ed92c61ffee5423be962bcdbe64c71e1f2fa > > Diff: https://reviews.apache.org/r/26346/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
