> On Oct. 7, 2014, 12:42 a.m., Jay Kreps wrote: > > core/src/main/scala/kafka/log/Log.scala, line 502 > > <https://reviews.apache.org/r/26346/diff/3/?file=714142#file714142line502> > > > > It is a bit subtle that you are checking for overflow this way. What we > > mean to check is just that there is sufficient room in the segment for this > > message, which I think we can do by checking: > > > > segment.size > config.segmentSize - messagesSize
Thanks Jay and Jun for the review and suggesstions. Please check the latest patch. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26346/#review55619 ----------------------------------------------------------- On Oct. 7, 2014, 8:39 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26346/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 8:39 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1670 > https://issues.apache.org/jira/browse/KAFKA-1670 > > > Repository: kafka > > > Description > ------- > > KAFKA-1670. Corrupt log files for segment.bytes values close to Int.MaxInt. > > > KAFKA-1670. Corrupt log files for segment.bytes values close to Int.MaxInt. > > > KAFKA-1670. Corrupt log files for segment.bytes values close to Int.MaxInt. > > > Merge remote-tracking branch 'origin/trunk' into KAFKA-1670 > > > Diffs > ----- > > core/src/main/scala/kafka/common/MessageSetSizeTooLargeException.scala > PRE-CREATION > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > core/src/test/scala/unit/kafka/log/LogManagerTest.scala > 59bd8a981b3fb8595dd6e790a30071092978a88d > core/src/test/scala/unit/kafka/log/LogTest.scala > 577d102fc2eb6bb1a72326141ecd431db6d66f04 > core/src/test/scala/unit/kafka/server/LogOffsetTest.scala > 9556ed92c61ffee5423be962bcdbe64c71e1f2fa > > Diff: https://reviews.apache.org/r/26346/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
