----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26346/#review55619 -----------------------------------------------------------
core/src/main/scala/kafka/log/Log.scala <https://reviews.apache.org/r/26346/#comment95982> I don't know if this comment is very intuitive. Let's just document that messageSize is the size of the message about to be appended and that this method will roll the log if either (1) the log is full, (2) the max time has elapsed, or (3) the index is full. core/src/main/scala/kafka/log/Log.scala <https://reviews.apache.org/r/26346/#comment95983> It is a bit subtle that you are checking for overflow this way. What we mean to check is just that there is sufficient room in the segment for this message, which I think we can do by checking: segment.size > config.segmentSize - messagesSize - Jay Kreps On Oct. 6, 2014, 4:48 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26346/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 4:48 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1670 > https://issues.apache.org/jira/browse/KAFKA-1670 > > > Repository: kafka > > > Description > ------- > > KAFKA-1670. Corrupt log files for segment.bytes values close to Int.MaxInt. > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > > Diff: https://reviews.apache.org/r/26346/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
