----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24653/#review51891 -----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/24653/#comment90566> Thanks for the patch - this is what I had in mind. The stack trace still shows up in the log though - I forgot that although swallow keeps the exception from bubbling up further, it still logs the exception which is annoying. However, the shutdown no longer hangs (as it used to) so your patch works. So I think it would be reasonable to just change this to swallow (which means swallowWarn) and let the exception show up in the logs for now. There is a separate effort to improve our logging convention and the current recommendation (for this instance) is to avoid showing the stack trace. That will be done in the jiras that come out of https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Error+Handling+and+Logging - Joel Koshy On Aug. 26, 2014, 2:33 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24653/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 2:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1577 > https://issues.apache.org/jira/browse/KAFKA-1577 > > > Repository: kafka > > > Description > ------- > > KAFKA-1577. Exception in ConnectionQuotas while shutting down. > > > KAFKA-1577. Exception in ConnectionQuotas while shutting down. > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 9693bc0b2d92377ee378e68f25b522bcaa836ddf > > Diff: https://reviews.apache.org/r/24653/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
