----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24653/#review51194 -----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/24653/#comment89227> Actually, I would recommend we don't do this here. During normal operation we should not be seeing this issue. It is only a corner case during shutdown. Instead I would just recommend wrapping the call to closeAll with a Utils.swallowError - since it (should) only happen during shutdown. If it happens any other time we need to know about it. Even the shutdown case can be handled with some synchronization but it is probably not worth the extra code. - Joel Koshy On Aug. 21, 2014, 2:58 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24653/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 2:58 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1577 > https://issues.apache.org/jira/browse/KAFKA-1577 > > > Repository: kafka > > > Description > ------- > > KAFKA-1577. Exception in ConnectionQuotas while shutting down. > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 9693bc0b2d92377ee378e68f25b522bcaa836ddf > > Diff: https://reviews.apache.org/r/24653/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
