----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24653/#review50495 -----------------------------------------------------------
I saw a bunch of whitespaces diffs. Do you know why those were introduced in the patch? core/src/main/scala/kafka/network/SocketServer.scala <https://reviews.apache.org/r/24653/#comment88321> While this may fix the NoSuchElementException, I wonder why the error happened in the first place as it may point to a bug in the way we are using the connection quotas. For example, are we trying to shut down the same socket channel twice somehow? Finding this will also help write a unit test for this, if possible. - Neha Narkhede On Aug. 13, 2014, 4:11 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24653/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 4:11 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1577 > https://issues.apache.org/jira/browse/KAFKA-1577 > > > Repository: kafka > > > Description > ------- > > KAFKA-1577. Exception in ConnectionQuotas while shutting down. > > > Diffs > ----- > > core/src/main/scala/kafka/network/SocketServer.scala > 9693bc0b2d92377ee378e68f25b522bcaa836ddf > > Diff: https://reviews.apache.org/r/24653/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
