Thanks for the KIP! Quick request for readability, can you please include the exact APIs that you're proposing to add or change under the "Public Interfaces" section? The KIP should display the actual method signature and any applicable javadocs for new public APIs.
You can look at other KIPs for a clear sense of what it should contain, but here's one example you could work from: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1036%3A+Extend+RecordDeserializationException+exception On Thu, Sep 26, 2024 at 6:22 PM Chia-Ping Tsai <chia7...@gmail.com> wrote: > > I think I’m actually OK with leaving it as leaveGroup with a lot of > documentation that warns users away from changing it arbitrarily. > > Pardon me, I just want to ensure we are all on the same page. > > 1. `leaveGroup=true`: `ClassicKafkaConsumer` sends a > `LeaveGroupRequest` for either the dynamic or static member. > 2. `leaveGroup=false`: `ClassicKafkaConsumer` does not send any ` > LeaveGroupRequest` for either the dynamic or static member. > 3. `leaveGroup=default` (current behavior): `ClassicKafkaConsumer` sends > a `LeaveGroupRequest` for dynamic member, and it does NOT send any > `ConsumerGroupHeartbeatRequest`for static member > 4. `leaveGroup=true`: `AsyncKafkaConsumer` sends a > `ConsumerGroupHeartbeatRequest` with "-1" epoch for either the dynamic > or > static member > 5. `leaveGroup=false`: `AsyncKafkaConsumer` sends a > `ConsumerGroupHeartbeatRequest` with "-2" epoch for the static member, > and > it does NOT send any `ConsumerGroupHeartbeatRequest` for dynamic member > 6. `leaveGroup=default` (current behavior): `AsyncKafkaConsumer` sends a > `ConsumerGroupHeartbeatRequest`with "-1" epoch for dynamic member and > "-2" epoch for static member > > Best, > Chia-Ping >
