> On June 2, 2014, 9:01 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/utils/ReplicationUtils.scala, line 57 > > <https://reviews.apache.org/r/21899/diff/3/?file=601101#file601101line57> > > > > parseLeaderAndIsr can also be part of ReplicationUtils. > > > > > > Sriharsha Chintalapani wrote: > parseLeaderAndIsr is used by other methods in ZkUtils. It should probably > be there and I'll implement a checker in ReplicationUtils that can be passed > to ZkUtils.conditionalUpdate
ZkUtils should ideally only have generic zookeeper utility methods, unrelated to Kafka logic. So pulling parseLeaderAndIsr into ReplicationUtils is right but if it is turning out to be a big change, could you file a JIRA to move Kafka specific replication logic from ZkUtils to ReplicationUtils? - Neha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21899/#review44544 ----------------------------------------------------------- On May 31, 2014, 10:50 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21899/ > ----------------------------------------------------------- > > (Updated May 31, 2014, 10:50 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1382 > https://issues.apache.org/jira/browse/KAFKA-1382 > > > Repository: kafka > > > Description > ------- > > KAFKA-1382. Update zkVersion on partition state update failures. > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 518d2df5ae702d8c0937e1f9603fd11a54e24be8 > core/src/main/scala/kafka/controller/KafkaController.scala > e776423b8a38da6f08b2262c8141abf2064d37d2 > core/src/main/scala/kafka/utils/ReplicationUtils.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/21899/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
