----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21899/#review44043 -----------------------------------------------------------
core/src/main/scala/kafka/utils/ZkUtils.scala <https://reviews.apache.org/r/21899/#comment78348> This is a generic API for conditional updates. Logic specific to Kafka shouldn't go here. Let's move it to a utils class. We have utils for Zk, API, clients but not for replication. Let's create a ReplicationUtils and add a common updateIsr utility. Controller and server can use that. Let's file a JIRA to refactor some existing utils related to replication to go to ReplicationUtils core/src/main/scala/kafka/utils/ZkUtils.scala <https://reviews.apache.org/r/21899/#comment78350> ZkUtils.parseLeaderAndIsr does this. - Neha Narkhede On May 26, 2014, 5:08 a.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21899/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 5:08 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1382 > https://issues.apache.org/jira/browse/KAFKA-1382 > > > Repository: kafka > > > Description > ------- > > KAFKA-1382. Update zkVersion on partition state update failures. > > > Diffs > ----- > > core/src/main/scala/kafka/utils/ZkUtils.scala > fcbe269b6057b45793ea95f357890d5d6922e8d4 > > Diff: https://reviews.apache.org/r/21899/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
