----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21899/#review44799 -----------------------------------------------------------
This looks great overall. However, something that I missed on my last review that I think is important - could we add unit tests using the checker for conditionalUpdatePersistentPath? I understand that reproducing the actual problem of retrying the conditional update due to zkclient reconnect is tricky. But I think we should be able to test a retry using the same data and another retry with a different leader or something. The purpose would be to ensure that the checker works properly as expected - Neha Narkhede On June 4, 2014, 7:30 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21899/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 7:30 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1382 > https://issues.apache.org/jira/browse/KAFKA-1382 > > > Repository: kafka > > > Description > ------- > > KAFKA-1382. Update zkVersion on partition state update failures. > > > KAFKA-1382. Update zkVersion on partition state update failures. > > > KAFKA-1382. Update zkVersion on partition state update failures. > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 518d2df5ae702d8c0937e1f9603fd11a54e24be8 > core/src/main/scala/kafka/controller/KafkaController.scala > e776423b8a38da6f08b2262c8141abf2064d37d2 > core/src/main/scala/kafka/controller/PartitionStateMachine.scala > 6457b56340a1b5440b07612f69dcffe4b051f919 > core/src/main/scala/kafka/utils/ReplicationUtils.scala PRE-CREATION > core/src/main/scala/kafka/utils/ZkUtils.scala > fcbe269b6057b45793ea95f357890d5d6922e8d4 > > Diff: https://reviews.apache.org/r/21899/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
