-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21616/#review44232
-----------------------------------------------------------


There seems to be a bunch of white space changes. Could we remove them?


system_test/utils/kafka_system_test_utils.py
<https://reviews.apache.org/r/21616/#comment78568>

    The comment probably needs to be changed.



system_test/utils/kafka_system_test_utils.py
<https://reviews.apache.org/r/21616/#comment78566>

    Do we need space btw props_file_path and hostname?



system_test/utils/kafka_system_test_utils.py
<https://reviews.apache.org/r/21616/#comment78567>

    Do we still need groupOption here?


- Jun Rao


On May 29, 2014, 12:47 a.m., Sriharsha Chintalapani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21616/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 12:47 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-924
>     https://issues.apache.org/jira/browse/KAFKA-924
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> KAKFA-924. Specify console consumer properties via a single --property 
> command line parameter.
> 
> 
> Diffs
> -----
> 
>   system_test/utils/kafka_system_test_utils.py 
> de02e471c4efd688f3915aa5854cc4b29860050d 
> 
> Diff: https://reviews.apache.org/r/21616/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Reply via email to