----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/#review43778 -----------------------------------------------------------
core/src/main/scala/kafka/consumer/ConsoleConsumer.scala <https://reviews.apache.org/r/21616/#comment78065> Can we follow the convention in the mirror maker tool? val consumerConfigOpt = parser.accepts("consumer.config", "Consumer config to consume from a source cluster. " + "You may specify multiple of these.") .withRequiredArg() .describedAs("config file") .ofType(classOf[String]) For that, we need to name it "consumer.config" and allow it to be a file. That way it is easier to use as well. Sorry, didn't realize that my initial suggestion was stale. - Neha Narkhede On May 18, 2014, 8:28 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21616/ > ----------------------------------------------------------- > > (Updated May 18, 2014, 8:28 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-924 > https://issues.apache.org/jira/browse/KAFKA-924 > > > Repository: kafka > > > Description > ------- > > KAFKA-924.Specify console consumer properties via a single --property command > line parameter. removed all consumer related top level command line arguments > including --group added --consumer-properties , users can pass properties > using > --consumer-properties=group.id=tesgroup,consumer.timeout.ms=-1,fetch.min.bytes=1 > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 24c92877cc7df20b82b7a438d39120b1caa3924d > > Diff: https://reviews.apache.org/r/21616/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
