----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21616/#review43991 -----------------------------------------------------------
core/src/main/scala/kafka/consumer/ConsoleConsumer.scala <https://reviews.apache.org/r/21616/#comment78232> This should be consumer.config for consistency core/src/main/scala/kafka/consumer/ConsoleConsumer.scala <https://reviews.apache.org/r/21616/#comment78341> This will not change the value of groupIdPassed. - Neha Narkhede On May 23, 2014, 9:47 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21616/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 9:47 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-924 > https://issues.apache.org/jira/browse/KAFKA-924 > > > Repository: kafka > > > Description > ------- > > KAFKA-924. Specify console consumer properties via a single --property > command line parameter. > > > KAFKA-924. Specify console consumer properties via a single --property > command line parameter. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 24c92877cc7df20b82b7a438d39120b1caa3924d > > Diff: https://reviews.apache.org/r/21616/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >