+1 Thanks Colin for all the iterations. My only request is to change "controller.connect" to "controller.quorum.voters." I think it's important to emphasize that this must be the full set of voters unlike "zookeeper.connect." In the future, I think we can consider supporting an additional config like "controller.connect" for brokers which can discover the voters more dynamically.
Best, Jason On Wed, Dec 16, 2020 at 7:36 AM Unmesh Joshi <unmeshjo...@gmail.com> wrote: > Went through the changes since the last discussion thread, and it's looking > in good shape. Thanks!. > + 1 (non-binding) > > On Wed, Dec 16, 2020 at 4:34 PM Tom Bentley <tbent...@redhat.com> wrote: > > > Thanks for the KIP Colin, it does a great job of clearly explaining some > > pretty complex changes. > > > > +1 (non-binding) > > > > Tom > > > > > > > > On Tue, Dec 15, 2020 at 7:13 PM Boyang Chen <reluctanthero...@gmail.com> > > wrote: > > > > > Thanks Colin for the great work to polish the KIP and reach this final > > > stage. +1 (binding) from me > > > > > > On Tue, Dec 15, 2020 at 9:11 AM David Arthur <mum...@gmail.com> wrote: > > > > > > > Colin, thanks for driving this. I just read through the KIP again > and I > > > > think it is in good shape. Exciting stuff! > > > > > > > > +1 binding > > > > > > > > -David > > > > > > > > On Sat, Dec 12, 2020 at 7:46 AM Ron Dagostino <rndg...@gmail.com> > > wrote: > > > > > > > > > Thanks for shepherding this KIP through the extended discussion, > > Colin. > > > > I > > > > > think we’ve ended up in a good place. I’m sure there will be more > > > tweaks > > > > > along the way, but the fundamentals are in place. +1 (non-binding) > > > from > > > > me. > > > > > > > > > > Ron > > > > > > > > > > > On Dec 11, 2020, at 4:39 PM, Colin McCabe <cmcc...@apache.org> > > > wrote: > > > > > > > > > > > > Hi all, > > > > > > > > > > > > I'd like to restart the vote on KIP-631: the quorum-based Kafka > > > > > Controller. The KIP is here: > > > > > > > > > > > > https://cwiki.apache.org/confluence/x/4RV4CQ > > > > > > > > > > > > The original DISCUSS thread is here: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://lists.apache.org/thread.html/r1ed098a88c489780016d963b065e8cb450a9080a4736457cd25f323c%40%3Cdev.kafka.apache.org%3E > > > > > > > > > > > > There is also a second email DISCUSS thread, which is here: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://lists.apache.org/thread.html/r1ed098a88c489780016d963b065e8cb450a9080a4736457cd25f323c%40%3Cdev.kafka.apache.org%3E > > > > > > > > > > > > Please take a look and vote if you can. > > > > > > > > > > > > best, > > > > > > Colin > > > > > > > > > > > > > > > > > -- > > > > David Arthur > > > > > > > > > >
