> On May 8, 2014, 10:48 p.m., Neha Narkhede wrote: > >
Thanks for the feedback. I added checkZkPathExists method to check if the offsets for given topic & groupid exists and removed tryCleanZookeeper method its not being used anywhere else in the code. - Sriharsha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21239/#review42550 ----------------------------------------------------------- On May 14, 2014, 6:33 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21239/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 6:33 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1431 > https://issues.apache.org/jira/browse/KAFKA-1431 > > > Repository: kafka > > > Description > ------- > > KAFKA-1431. ConsoleConsumer - Option to clean zk consumer path changed > options --delete-consumer-offsets. It checks if existing offsets for givent > topic & groupId exists and throws error if user didn't specifiy > --delete-consumer-offsets > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 0f62819be0562f62c0f778bd20ead053f01a6f2f > > Diff: https://reviews.apache.org/r/21239/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
