----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21239/#review42550 -----------------------------------------------------------
core/src/main/scala/kafka/consumer/ConsoleConsumer.scala <https://reviews.apache.org/r/21239/#comment76355> This is great. In addition to this, if the user picks the --from-beginning option and we find existing offset information, we should probably throw an error saying "Found previous offset information for this group <group-name>. Please use the --delete-consumer-path option to delete the previous offset metadata". Also, what if the user runs the console consumer with both --from-beginning and --delete-consumer-path? This should be allowed, I guess. Another suggestion - can we rename the new option to --delete-consumer-offsets? - Neha Narkhede On May 8, 2014, 9:58 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21239/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 9:58 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1431 > https://issues.apache.org/jira/browse/KAFKA-1431 > > > Repository: kafka > > > Description > ------- > > KAFKA-1431. ConsoleConsumer - Option to clean zk consumer path. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 0f62819be0562f62c0f778bd20ead053f01a6f2f > > Diff: https://reviews.apache.org/r/21239/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
