----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21239/#review43113 -----------------------------------------------------------
core/src/main/scala/kafka/consumer/ConsoleConsumer.scala <https://reviews.apache.org/r/21239/#comment77127> Since this is a command line tool, we should print the message to stdout, instead of logging, so that users can see the message on the console. - Jun Rao On May 14, 2014, 7:08 p.m., Sriharsha Chintalapani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21239/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 7:08 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1431 > https://issues.apache.org/jira/browse/KAFKA-1431 > > > Repository: kafka > > > Description > ------- > > KAFKA-1431. ConsoleConsumer - Option to clean zk consumer path changed > options --delete-consumer-offsets. It checks if existing offsets for givent > topic & groupId exists and throws error if user didn't specifiy > --delete-consumer-offsets > > > KAFKA-1431.ConsoleConsumer - Option to clean zk consumer path. just checking > consumers/groupId/offsets is good enough, removed for checking topicId under > offsets. > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsoleConsumer.scala > 0f62819be0562f62c0f778bd20ead053f01a6f2f > > Diff: https://reviews.apache.org/r/21239/diff/ > > > Testing > ------- > > > Thanks, > > Sriharsha Chintalapani > >
