----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39635 -----------------------------------------------------------
Just one minor comment. Other than that, it looks great! We can check it in after this comment is addressed core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/19957/#comment72118> It's worth adding a get API to the MetadataCache and make cache private. - Neha Narkhede On April 5, 2014, 12:45 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19957/ > ----------------------------------------------------------- > > (Updated April 5, 2014, 12:45 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1356 > https://issues.apache.org/jira/browse/KAFKA-1356 > > > Repository: kafka > > > Description > ------- > > KAFKA-1356 Improve topic metadata handling in kafka api > > > Diffs > ----- > > core/src/main/scala/kafka/api/TopicMetadata.scala > 0513a59ed94e556894b3515dc38666ee9a66ae3d > core/src/main/scala/kafka/controller/KafkaController.scala > fcabd0da201ccd478f5884bcca9b75a8c8ea8373 > core/src/main/scala/kafka/server/KafkaApis.scala > c068ef69207c351eec413a595f1747c59f8b3983 > core/src/test/scala/unit/kafka/admin/AdminTest.scala > d5644ea40ec7678b975c4775546b79fcfa9f64b7 > core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala > 22bb6f2847b8895f8fbba6c531963ebb0fffe2ca > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 2054c25bbced6bd90c092a1974975732ad346146 > > Diff: https://reviews.apache.org/r/19957/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
