> On April 1, 2014, 8:20 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java, > > line 138 > > <https://reviews.apache.org/r/19879/diff/1/?file=544093#file544093line138> > > > > Do we still need this sensor, since the only metric it has is gone now?
Yes, that actually has a metric it just isn't added there (it is added in Sender). - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19879/#review39195 ----------------------------------------------------------- On April 1, 2014, 7:49 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19879/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 7:49 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1251 > https://issues.apache.org/jira/browse/KAFKA-1251 > > > Repository: kafka > > > Description > ------- > > KAFKA-1251 Further metric naming standardization. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 8c1c5751a9186e6bc3196d152e4c3e948cc34b39 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > c92bfbcd02b5444d2673b00f9699a553a40a877a > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 5b801e47faab3d365b771396fb6e9f7f66600109 > > Diff: https://reviews.apache.org/r/19879/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
