> On April 2, 2014, 1:55 a.m., Jun Rao wrote: > > Do we need both io-ratio and io-wait-ratio? It seems io-ratio = 1 - > > io-wait-ratio. Other than that, looks good to me.
Yes, you need both. There are really three things: 1. Time waiting on I/O 2. Time doing I/O 3. Time in Sender doing actual request prep and processing. (3) is actually a pretty substantial portion and is implicitly 1.0 - (1)+(2) - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19879/#review39230 ----------------------------------------------------------- On April 1, 2014, 7:49 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19879/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 7:49 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1251 > https://issues.apache.org/jira/browse/KAFKA-1251 > > > Repository: kafka > > > Description > ------- > > KAFKA-1251 Further metric naming standardization. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 8c1c5751a9186e6bc3196d152e4c3e948cc34b39 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > c92bfbcd02b5444d2673b00f9699a553a40a877a > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 5b801e47faab3d365b771396fb6e9f7f66600109 > > Diff: https://reviews.apache.org/r/19879/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
