> On April 1, 2014, 8:21 p.m., Jay Kreps wrote: > > clients/src/main/java/org/apache/kafka/common/network/Selector.java, line > > 432 > > <https://reviews.apache.org/r/19879/diff/1/?file=544095#file544095line432> > > > > Here was my convention: > > 1. All rates are in seconds (the default) > > 2. All latencies are in ms unless otherwise noted. > > 3. A few things require finer grained measurement than 1 ms and for > > these I called it out in the name so this would not be confusing. > > Timothy Chen wrote: > Then perhaps io-ratio needs to add a ns in it as it's in nanoseconds > right?
No actually that one is a ratio since it is a rate per nanosecond. So a value of 0.8 would indicate that we spent 80% of our time doing I/O. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19879/#review39196 ----------------------------------------------------------- On April 1, 2014, 7:49 p.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19879/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 7:49 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1251 > https://issues.apache.org/jira/browse/KAFKA-1251 > > > Repository: kafka > > > Description > ------- > > KAFKA-1251 Further metric naming standardization. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 8c1c5751a9186e6bc3196d152e4c3e948cc34b39 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > c92bfbcd02b5444d2673b00f9699a553a40a877a > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 5b801e47faab3d365b771396fb6e9f7f66600109 > > Diff: https://reviews.apache.org/r/19879/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
