Nikolay, I agree with all points. But one thing is very uncertain. What contribution is really troublesome (and consequently should be fixed quickly or reverted)? But in fact it is a topic for a separate discussion.
In current case about deprecation I agree with Nikolay and Anton. It should be reverted until we have a substitution for beforeTestsStarted method. пн, 18 февр. 2019 г. в 13:01, Nikolay Izhikov <nizhi...@apache.org>: > > Ivan, I think we should use common sense here. > > 1. We should keep master consistent. > 2. Contributors should try to fix issues appeared with their contribution. > > Do you agree with this? > > If some contributor can't fix issue quickly, is't completely OK. > But, we should find another contributor, or revert contribution and rework > it properly. > > There is no problem with some bad commit(I made such too). > There is issues with bad commit fixing time. > > > пн, 18 февр. 2019 г. в 12:34, Павлухин Иван <vololo...@gmail.com>: > > > Nikolay, > > > > I agree with you and Anton that discussed deprecation is not a good thing. > > > > But it is quite interesting for me personally where our community > > declared actions which should be taken against troublesome > > contributions. > > > > пн, 18 февр. 2019 г. в 12:11, Nikolay Izhikov <nizhi...@apache.org>: > > > > > > Ivan. > > > > > > Please, use the quote right: "We should avoid any discussions *this > > time*." > > > This means - "We should *fix the issue* as quick as we can and discuss > > > correct improvement after" > > > > > > Should we live this long with wrong deprecation? > > > I don't think so. > > > > > > > > > пн, 18 февр. 2019 г. в 11:58, Павлухин Иван <vololo...@gmail.com>: > > > > > > > Anton, > > > > > > > > Could you please provide a link to a section in Ignite development > > > > process document (or alike) stating in what cases "we should avoid a > > > > discussion" and proceed with steps suggested by you? Sincerely, I am > > > > not aware. Sorry if I missed it. > > > > > > > > пн, 18 февр. 2019 г. в 11:33, Anton Vinogradov <a...@apache.org>: > > > > > > > > > > Oleg, > > > > > > > > > > Task creation is not equaled to task in progress. > > > > > It means nothing, to be honest. > > > > > Are you going to fix this issue? > > > > > > > > > > That's not the first time we have such discussion at the community. > > > > > So, now I have a clear vision. > > > > > Since you contributed code with problems you are responsible to > > > > > - fix them or > > > > > - find the person who able to fix or > > > > > - the code will be rolled back. > > > > > > > > > > We should avoid any discussions this time. > > > > > Please tell me what case should we chose. > > > > > > > > > > On Sun, Feb 17, 2019 at 10:14 AM oignatenko <oignate...@gridgain.com > > > > > > > wrote: > > > > > > > > > > > Hi Anton, > > > > > > > > > > > > I would like to re-check if I correctly understand the plan. > > > > > > > > > > > > So, we are going to remove deprecation from these two methods - > > and the > > > > > > reason for this is that the way recommended instead of these > > methods > > > > makes > > > > > > it less convenient to start and stop the grid. > > > > > > > > > > > > Now, regarding the mentioned inconvenient way, we also plan to > > improve > > > > it > > > > > > (JIRA task IGNITE-11240 if memory serves). My understanding is, > > after > > > > we > > > > > > are > > > > > > done with it, we will recover deprecation for these methods > > because as > > > > > > follows from above, inconvenience of using the recommended way was > > the > > > > only > > > > > > reason to remove it. > > > > > > > > > > > > Please feel free to correct if I missed something. > > > > > > > > > > > > regards, Oleg > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > > > > > > > > > > > > > > > > > > > > > -- > > > > Best regards, > > > > Ivan Pavlukhin > > > > > > > > > > > > -- > > Best regards, > > Ivan Pavlukhin > > -- Best regards, Ivan Pavlukhin
