Oleg, Still, see beforeTestsStarted is deprecated. Since we found this deprecation was incorrect, we have to roll it back. Please fix the issue.
On Thu, Feb 7, 2019 at 5:18 PM oignatenko <oignate...@gridgain.com> wrote: > Hi Ivan, > > For the sake of precision, startGrid() is currently overridden in one of > subclasses of GridAbstractTest. This means that we would have to somehow > handle that when changing this method to static. Same thing is with another > solid candidate to making static, stopAllGrids(boolean), which is also > currently overridden in another subclass. > > That said, above issues look relatively minor and manageable and overall I > think it would be better to redesign GridAbstractTest as you suggested. > > regards, Oleg > > > Павлухин Иван wrote > > Hi, > > > > AFAIK various startGrid* methods of GridAbstractTest are not tied to > > concrete instance of test class. I think that a we can make them > > static. Also same can be done for some other methods and all they can > > be extracted into static utility class like GridTestSupport in order > > to reduce GridAbstractTest class size and separate concerns. > > > > What do you think? > > > > чт, 7 февр. 2019 г. в 09:44, oignatenko < > > > oignatenko@ > > > >: > >> > >> Hi Anton, > >> > >> You can start and stop grid from static context required by mentioned > >> annotations using code like: > >> > >> MyTestClass.class.newInstance().startGrid(); > >> > >> This way doesn't look very convenient and I created JIRA task to address > >> that: > >> > >> https://issues.apache.org/jira/browse/IGNITE-11240 > >> > >> Does that address your question? > >> > >> regards, Oleg > >> > >> > >> > >> -- > >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ > > > > > > > > -- > > Best regards, > > Ivan Pavlukhin > > > > > > -- > Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >
