Hi Anton, I re-checked details of the JIRA task you mentioned [1] and it looks like finished to me, sorry. Ticket description is a list of specific items to be addressed and as far as I can tell all of them are done.
Since you mentioned review, changes made per this ticket were fairly thoroughly reviewed: for example respective PR [2] lists five commits that were done to address review comments. And as far as I remember at the time of review we had a solid consensus that scope of these changes is determined by concrete items listed in task description. Note by the way that after merge of these changes it became impossible to write JUnit3 tests inheriting GridAbstractTest. One can probably call this part of the changes final. --- Speaking of JUnit3TestLegacySupport, TODOs are there to help readers see that some specific parts of code in this class are expected to change per particular JIRA task. That it should be (eventually) completely removed or somehow reworked in the future is irrelevant here because this can be done gradually, in different time, for different reasons and by different JIRA tasks. --- With regards to what you call "final Junit3 removal", I find it hard to comprehend what exactly you want nor how this can be expressed in practical actions of changing concrete code. In contrast, the way how migration effort was explained at dev list discussion that started it looks clear and understandable: "Is it time to start translating tests to Unit 4 style?" (worth noting that it further goes into even more concrete and practical explanation of what change is desired and why, explaining that we want to be able to use @Ignore annotation to simplify maintenance at Teamcity) And umbrella JIRA task that followed this discussion [4] also has actionable description of what is to be done: "This task is to migrate all tests to single uniform version Junit 4". Speaking in terms of mentioned discussion and JIRA task, this is all done and over - finished and verified ([5]). In fact, anyone can verify whether migration is completed by doing plain text search for "junit.framework" in project files and reviewing search results to make sure that there are no test classes / suites inheriting the old API (JUnit 3 package names start with junit.framework). It's very easy, just give it a try. Summing up, I don't know what you have in mind speaking of what else should be done or finalized, but whatever it is, I can't see how it would fit into the scope of our original discussion here and of original JIRA task. [1] https://issues.apache.org/jira/browse/IGNITE-10177 [2] https://github.com/apache/ignite/pull/5615 [3] http://apache-ignite-developers.2346864.n4.nabble.com/Is-it-time-to-move-forward-to-JUnit4-5-td29608.html [4] https://issues.apache.org/jira/browse/IGNITE-10173 [5] https://issues.apache.org/jira/browse/IGNITE-10629 regards, Oleg Anton Vinogradov-2 wrote > Oleg, > > You may use TODO if it is really necessary. > I see no reason to have any todo at JUnit3TestLegacySupport class since > it's already marked as legacy and should be removed in the future. > And we should have an issue about this removal. > > Why you closed GNITE-10177 "cleanup Junit 3 from the project" since you're > not finished work? > Why now we discuss incorrect deprecation instead of making proper fix > design in advance? > > One more question to the committer. > Dmitriy, > > Why incomplete fix was merged to master without any issues responsible for > finalization? > Who's now responsible for final Junit3 removal? > > On Mon, Feb 18, 2019 at 4:22 PM oignatenko < > oignatenko@ > > wrote: > >> Hi Anton, >> >> I removed @deprecated from javadoc, thanks for noticing. PR #6122 [1] is >> updated. >> >> As for TODOs, I think you are wrong here because Ignite coding guidelines >> [2] not only explicitly allow these but also explain the format in which >> these should be presented. If you find violations of recommended TODOs >> format, please let me know. >> >> regards, Oleg >> >> [1]: https://github.com/apache/ignite/pull/6122 >> [2]: >> >> https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-TODOs >> >> >> >> -- >> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/ >> -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
