Hi all! So guys let’s make a decision. We leave code in current state as I suggest or change module naming according Dmitry’s suggestion. ср, 11 апр. 2018 г. в 1:54, Denis Magda <dma...@apache.org>:
> Roman, > > Your suggestion sounds reasonable to me. Backing it up. > > -- > Denis > > On Tue, Apr 10, 2018 at 2:50 PM, Роман Меерсон <homich1...@gmail.com> > wrote: > > > Hi all! > > > > IMHO if we do so we'll produce big pain for everybody while migrating on > > new version, because ones should change method and others should change > > their poms. This change would be backward incompatible so it probably > > should follow with major version upgrade, but I'm not sure about it. > > > > Otherwise if we leave current state( spring-data for old and > > spring-data-2.0 for new) we could support old users who probably use > spring > > data 1.0 (because spring data 2.0 release was not so long ago) and > provide > > new functionality for users who want to use new spring data. > > In this case old users wouldn't change any in their code except ignite > > version, and new users would include ignite in their Pom anyway and could > > choose which module of spring data to bring. > > > > After some time (probably on 3.0 release) we could change naming as Denis > > suggested. > > > > Anyway I leave this decision up to you, just tell me what is the way to > > finish this PR. > > > > Regards, Roman. > > > > ср, 11 апр. 2018 г. в 1:35, Denis Magda <dma...@apache.org>: > > > > > In our Hibernate integration we define following two modules to > > > distinguish incompatible versions: > > > > > > - ignite-hiberbate_4.2 > > > - ignite-hibernate_5.1 > > > > > > In Spark we have: > > > > > > - ignite-spark > > > - ignite-spark_2.10 > > > > > > After thinking this over, I would do the following with Spring Data: > > > > > > - ignite-spring-data for the latest Sprind Data 2.0 > > > - ignite-spring-data_1.0 > > > > > > What do you think? > > > > > > -- > > > Denis > > > > > > On Tue, Apr 10, 2018 at 3:50 AM, Dmitry Pavlov <dpavlov....@gmail.com> > > > wrote: > > > > > >> Thank you, Roman. > > >> > > >> Igniters, > > >> > > >> IMO we should consider one more alternative - renaming of old module > and > > >> package names. Users, which prefer to stay on previous version will be > > >> requiered to update their pom's. In the same time users which are > ready > > to > > >> migrate to spring data 2.0 will need to update methods naming. > > >> > > >> Denis M, what would you say? > > >> > > >> Sincerely, > > >> Dmitriy Pavlov > > >> > > >> вт, 10 апр. 2018 г. в 11:27, Роман Меерсон <homich1...@gmail.com>: > > >> > > >>> Hi Dmitry! > > >>> > > >>> I`ve just commited new fix. I renamed package of new module to > > >>> springdata20, it helps us to separate old implementation from new and > > also > > >>> should fix all compilation errors. > > >>> > > >>> пн, 9 апр. 2018 г. в 23:54, Роман Меерсон <homich1...@gmail.com>: > > >>> > > >>>> Ok, I'll check it, but I haven't face this problem. > > >>>> If I'll find same issue, what is the proper way? Renaming to > something > > >>>> like Ignite2QueryGenerator or module removing? > > >>>> пн, 9 апр. 2018 г. в 23:40, Dmitry Pavlov <dpavlov....@gmail.com>: > > >>>> > > >>>>> There are 2 classes IgniteQueryGenerator with same package name. > > >>>>> Ignite in Idea can't compile. > > >>>>> > > >>>>> > > >>>>> пн, 9 апр. 2018 г., 21:38 Роман Меерсон <homich1...@gmail.com>: > > >>>>> > > >>>>>> Hi Dmitry! > > >>>>> > > >>>>> > > >>>>>> Could you specify where you find conflict? Because I don’t have > any. > > >>>>>> пн, 9 апр. 2018 г. в 21:09, Dmitry Pavlov <dpavlov....@gmail.com > >: > > >>>>>> > > >>>>>>> Hi Denis, > > >>>>>>> > > >>>>>>> could we support just one version instead of leaving compatible > > >>>>>>> module? > > >>>>>>> > > >>>>>>> Sincerely, > > >>>>>>> Dmitriy Pavlov > > >>>>>>> > > >>>>>>> пн, 9 апр. 2018 г. в 20:08, Dmitry Pavlov <dpavlov....@gmail.com > >: > > >>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>>> пн, 9 апр. 2018 г. в 20:07, Dmitry Pavlov < > dpavlov....@gmail.com > > >: > > >>>>>>>> > > >>>>>>>>> Hi Roman, > > >>>>>>>>> > > >>>>>>>>> I've applied PR locally and I have class name conflict at least > > >>>>>>>>> for > > >>>>>>>>> org.apache.ignite.springdata.repository.query. > > IgniteQueryGenerator > > >>>>>>>>> > > >>>>>>>>> How could we solve it? Is it better to rename class for new > > plugin > > >>>>>>>>> version? > > >>>>>>>>> > > >>>>>>>>> Sincerely, > > >>>>>>>>> Dmitriy Pavlov > > >>>>>>>>> > > >>>>>>>>> пт, 6 апр. 2018 г. в 17:38, Dmitry Pavlov < > dpavlov....@gmail.com > > >: > > >>>>>>>>> > > >>>>>>>>>> Excellend picture. I remember about this change. > > >>>>>>>>>> > > >>>>>>>>>> If Denis M. would be able to look througt the changes faster > > than > > >>>>>>>>>> me, I can merge without detailed review. > > >>>>>>>>>> > > >>>>>>>>>> пт, 6 апр. 2018 г. в 16:15, Роман Меерсон < > homich1...@gmail.com > > >: > > >>>>>>>>>> > > >>>>>>>>>>> OK > > >>>>>>>>>>> > > >>>>>>>>>>> [image: 1486924635147168240.jpg] > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> пт, 6 апр. 2018 г. в 17:08, Igor Sapego <isap...@apache.org > >: > > >>>>>>>>>>> > > >>>>>>>>>>>> Hi, > > >>>>>>>>>>>> Well, Dmitry has said he's going to merge it in 3-4 days 2 > > days > > >>>>>>>>>>>> ago, > > >>>>>>>>>>>> so I guess, the merge is going to happen in 1-2 days or so. > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> Best Regards, > > >>>>>>>>>>>> Igor > > >>>>>>>>>>>> > > >>>>>>>>>>>> On Fri, Apr 6, 2018 at 3:48 PM, Роман Меерсон < > > >>>>>>>>>>>> homich1...@gmail.com> wrote: > > >>>>>>>>>>>> > > >>>>>>>>>>>> > Hi all! > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > As i see everything is awesome and there is no objections, > > so > > >>>>>>>>>>>> when my PR > > >>>>>>>>>>>> > would be merged? > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > чт, 5 апр. 2018 г. в 18:58, Вячеслав Коптилин < > > >>>>>>>>>>>> slava.kopti...@gmail.com>: > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > Thank you, Roman! > > >>>>>>>>>>>> > > > > >>>>>>>>>>>> > > 2018-04-05 17:49 GMT+03:00 Роман Меерсон < > > >>>>>>>>>>>> homich1...@gmail.com>: > > >>>>>>>>>>>> > > > > >>>>>>>>>>>> > > > Hi Slava, > > >>>>>>>>>>>> > > > > > >>>>>>>>>>>> > > > Fixed > > >>>>>>>>>>>> > > > > > >>>>>>>>>>>> > > > чт, 5 апр. 2018 г. в 18:41, Вячеслав Коптилин < > > >>>>>>>>>>>> > slava.kopti...@gmail.com > > >>>>>>>>>>>> > > >: > > >>>>>>>>>>>> > > > > > >>>>>>>>>>>> > > > > Hi Roman, > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>>> > > > > please take into account my comment > > >>>>>>>>>>>> IgniteQueryGenerator.java > > >>>>>>>>>>>> > > > > < > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>>> https://reviews.ignite.apache.org/ignite/review/IGNT-CR-541 > ? > > >>>>>>>>>>>> > > > commentId=de43c65f-9ac7-4080- > > 9904-aec119138c94&filePath=/ > > >>>>>>>>>>>> > > > modules/spring-data-2.0/src/ > > main/java/org/apache/ignite/ > > >>>>>>>>>>>> > > > springdata/repository/query/IgniteQueryGenerator.java > > >>>>>>>>>>>> > > > > > > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>>> > > > > Best regards, > > >>>>>>>>>>>> > > > > Slava. > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>>> > > > > 2018-04-05 14:59 GMT+03:00 Роман Меерсон < > > >>>>>>>>>>>> homich1...@gmail.com>: > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>>> > > > > > Ok, so waiting for accept and commit > > >>>>>>>>>>>> > > > > > > > >>>>>>>>>>>> > > > > > чт, 5 апр. 2018 г. в 15:29, Alexey Kukushkin < > > >>>>>>>>>>>> > > > kukushkinale...@gmail.com > > >>>>>>>>>>>> > > > > >: > > >>>>>>>>>>>> > > > > > > > >>>>>>>>>>>> > > > > > > Roman, > > >>>>>>>>>>>> > > > > > > > > >>>>>>>>>>>> > > > > > > Just pay commiter's (Dmitry Pavlov will most > > likely > > >>>>>>>>>>>> commit your > > >>>>>>>>>>>> > > code) > > >>>>>>>>>>>> > > > > > > attention to include the new test suite to > > TeamCity > > >>>>>>>>>>>> > configuration. > > >>>>>>>>>>>> > > > > > > > > >>>>>>>>>>>> > > > > > > > >>>>>>>>>>>> > > > > > > >>>>>>>>>>>> > > > > > >>>>>>>>>>>> > > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > >>>>>>>>>>> > > > > > >
