+1 It is good to have consistency within the RowDelta API. And I think it is a good idea in general to use "remove" to refer to removing a file from metadata, rather than "delete" because you can add or remove delete files.
On Thu, May 29, 2025 at 11:46 AM Russell Spitzer <russell.spit...@gmail.com> wrote: > Ryan pointed out to me that whenI added the "deleteFile" method I was not > following > the convention already being used within the RowDelta operation and > instead had copied > the OverwriteFiles API. To fix this I think it would be great to change > the API to "removeRows" > to match the other APIs in the class. > > We haven't done a release with this API yet so this is not a breaking > change to any public > APIs. > > > https://github.com/apache/iceberg/pull/13184 >
