Yes, agree (we can do both actually, but at least, at release prep :)). I will propose a check-legal script (as we have check-license for rat) in dev folder to check LICENSE/NOTICE content.
Regards JB On Mon, Apr 14, 2025 at 11:58 AM Eduard Tudenhöfner <etudenhoef...@apache.org> wrote: > > I think rather than having to update the LICENSE/NOTICE files on every > version bump (which might be forgotten and requires manual work) maybe we > should do this once during release preparation. > > On Mon, Apr 14, 2025 at 11:47 AM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: >> >> -1 (non binding) >> >> I checked: >> - signature and checksum are OK >> - build works >> - ASF header is present in all expected files >> - no binary file in the source distribution >> - LICENSE/NOTICE in aws-bundle is not correct: netty version should be >> 4.1.115.Final >> - LICENSE/NOTICE in azure-bundle is not correct: azure-identity >> version should be 1.15.0, netty version should be 4.1.115.Final >> - LICENSE/NOTICE in gcp-bundle is not correct: jackson version should >> be 2.18.2, google api-common version should be 2.46.1, gax version >> should be 2.63.1, google-api-client version should be 2.7.2, google >> gapic version should be 2.50.0, gson version should be 2.12.1, guava >> version should be 33.4.0-jre, google-http-client version should be >> 1.46.3, protobuf-java version should be 4.29.4, commons-codec version >> should be 1.18.0, grpc version should be 1.70.0, opentelemetry version >> should be 1.47.0 >> - LICENSE/NOTICE in the kafka-connect-runtime distribution is not >> correct: gax version should be 2.63.1, google api-common version >> should be 2.46.1, google-cloud-storage version should be 2.50.0, >> proto-google-common-protos version should be 2.54.1, proto-google-iam >> version should be 1.49.1, google-auth-library version should be >> 1.33.1, google-cloud-core version should be 2.53.1, gson version >> should be 2.12.1, guava version should be 33.4.0, google-http-client >> version should be 1.46.3, protobuf-java version should be 4.29.4, >> commons-codec version should be 1.18.0, grpc version should be 1.70.0, >> netty version should be 4.1.115.Final >> >> I think some dependabot PRs have been merged without aligning LICENSE/NOTICE. >> >> I will provide PRs to fix that. >> >> Regards >> JB >> >> On Thu, Apr 10, 2025 at 12:26 AM Ajantha Bhat <ajanthab...@gmail.com> wrote: >> > >> > Hi Everyone, >> > >> > I propose that we release the following RC as the official Apache Iceberg >> > 1.9.0 release. >> > >> > The commit ID is e56ec11215e7b9fec6ffd1ea435e008852454db0 >> > * This corresponds to the tag: apache-iceberg-1.9.0-rc0 >> > * https://github.com/apache/iceberg/commits/apache-iceberg-1.9.0-rc0 >> > * >> > https://github.com/apache/iceberg/tree/e56ec11215e7b9fec6ffd1ea435e008852454db0 >> > >> > The release tarball, signature, and checksums are here: >> > * https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.9.0-rc0 >> > >> > You can find the KEYS file here: >> > * https://downloads.apache.org/iceberg/KEYS >> > >> > Convenience binary artifacts are staged on Nexus. The Maven repository URL >> > is: >> > * https://repository.apache.org/content/repositories/orgapacheiceberg-1188/ >> > >> > Please download, verify, and test. >> > >> > Please vote in the next 72 hours. >> > >> > [ ] +1 Release this as Apache Iceberg 1.9.0 >> > [ ] +0 >> > [ ] -1 Do not release this because... >> > >> > Only PMC members have binding votes, but other community members are >> > encouraged to cast >> > non-binding votes. This vote will pass if there are 3 binding +1 votes and >> > more binding >> > +1 votes than -1 votes. >> > >> > Special thanks to Eduard and Fokko for helping me with the artifacts >> > upload. >> > >> > - Ajantha
