+1 (binding) Checked licensing and sha and gpg sig
On Mon, Jan 27, 2025 at 3:02 PM Fokko Driesprong <fo...@apache.org> wrote: > +1 (binding) > > Ran signature/checksum/license: > > *➜ **Desktop* gpg --verify apache-iceberg-1.7.2.tar.gz.asc > > gpg: assuming signed data in 'apache-iceberg-1.7.2.tar.gz' > > gpg: Signature made Sun Jan 26 21:23:14 2025 CET > > gpg: using RSA key FCD3779E399C53D995FC82A35171BA3E54493550 > > gpg: Good signature from "Fokko Driesprong <fo...@apache.org>" [unknown] > > gpg: WARNING: This key is not certified with a trusted signature! > > gpg: There is no indication that the signature belongs to the > owner. > > Primary key fingerprint: FCD3 779E 399C 53D9 95FC 82A3 5171 BA3E 5449 > 3550 > > *➜ **Desktop* shasum -a 512 --check apache-iceberg-1.7.2.tar.gz.sha512 > > apache-iceberg-1.7.2.tar.gz: OK > > *➜* *Desktop* tar xzf apache-iceberg-1.7.2.tar.gz > > *➜ **Desktop* cd apache-iceberg-1.7.2 > > *➜ **apache-iceberg-1.7.2* ./dev/check-license > > Attempting to fetch rat > > ERROR: Ignored 0 lines in your exclusion files as comments or empty lines. > > RAT checks passed. > More importantly, at PyIceberg we're able to bump to 1.7.2 > <https://github.com/apache/iceberg-python/pull/1581/>. We're still at > 1.6.0 because of #11858 <https://github.com/apache/iceberg/pull/11858>. > > Kind regards, > Fokko > > > Op ma 27 jan 2025 om 16:15 schreef Jean-Baptiste Onofré <j...@nanthrax.net>: > >> Hi Manu >> >> We have some "duplicated" issues on the 1.7.2 milestone. >> For instance, https://github.com/apache/iceberg/pull/11812 and >> https://github.com/apache/iceberg/pull/11817 are the same but only the >> 11817 is for 1.7.x. >> Same for https://github.com/apache/iceberg/pull/11954 and >> https://github.com/apache/iceberg/pull/11971. >> >> That explains the "gap". >> >> Let me update the milestone for issues targeting 1.8.0 (not 1.7.2). >> >> Regards >> JB >> >> On Mon, Jan 27, 2025 at 3:46 PM Manu Zhang <owenzhang1...@gmail.com> >> wrote: >> > >> > Hi JB, >> > >> > Thanks for driving the release. It looks the 1.7.2 milestone has more >> changes than diffs between 1.7.2-rc0 and 1.7.1. >> > >> > Regards, >> > Manu >> > >> > On Mon, Jan 27, 2025 at 10:36 PM Jean-Baptiste Onofré <j...@nanthrax.net> >> wrote: >> >> >> >> Hi, >> >> >> >> as 1.7.x is "broken", 1.7.2 makes sense. 1.8.0 brings new features. >> >> >> >> Regards >> >> JB >> >> >> >> On Mon, Jan 27, 2025 at 6:37 AM Ajantha Bhat <ajanthab...@gmail.com> >> wrote: >> >> > >> >> > Hi JB and Fokko, >> >> > >> >> > Since 1.8.0 RC is planned for tomorrow[1], >> >> > Just wondering if we really need 1.7.2? >> >> > >> >> > [1] https://lists.apache.org/thread/wvz5sd7pmh5ww1yqhsxpt1kwf993276j >> >> > >> >> > - Ajantha >> >> > >> >> > On Mon, Jan 27, 2025 at 2:11 AM Jean-Baptiste Onofré < >> j...@nanthrax.net> wrote: >> >> >> >> >> >> Hi everyone, >> >> >> >> >> >> I propose that we release the following RC as the official Apache >> >> >> Iceberg 1.7.2 release. >> >> >> >> >> >> The commit ID is c2105b2634becf68b3fdabd0ee6fb0b6e93d4f0c >> >> >> * This corresponds to the tag: apache-iceberg-1.7.2-rc0 >> >> >> * >> https://github.com/apache/iceberg/commits/apache-iceberg-1.7.2-rc0 >> >> >> * >> https://github.com/apache/iceberg/tree/c2105b2634becf68b3fdabd0ee6fb0b6e93d4f0c >> >> >> >> >> >> The release tarball, signature, and checksums are here: >> >> >> * >> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.7.2-rc0 >> >> >> >> >> >> You can find the KEYS file here: >> >> >> * https://downloads.apache.org/iceberg/KEYS >> >> >> >> >> >> Convenience binary artifacts are staged on Nexus. The Maven >> repository URL is: >> >> >> * >> https://repository.apache.org/content/repositories/orgapacheiceberg-1180/ >> >> >> >> >> >> For the changes, checkout the Milestone: >> >> >> https://github.com/apache/iceberg/milestone/52?closed=1 >> >> >> >> >> >> Please download, verify, and test. Please vote in the next 72 hours. >> >> >> >> >> >> [ ] +1 Release this as Apache Iceberg 1.7.2 >> >> >> [ ] +0 >> >> >> [ ] -1 Do not release this because... >> >> >> >> >> >> Only PMC members have binding votes, but other community members are >> >> >> encouraged to cast non-binding votes. This vote will pass if there >> are >> >> >> 3 binding +1 votes and more binding +1 votes than -1 votes. >> >> >> >> >> >> Thanks, >> >> >> Regards >> >> >> JB & Fokko >> >